Async wf consumer manager should watch its enabled/disabled state instead of relying on restart #5966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of relying on restart
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
taylanisikdemir
force-pushed
the
taylan/consumer_liveness
branch
from
57c56dc
to
45a4d81
Compare
Shaddoll
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Worker creates the ConsumerManager only if
worker.enableAsyncWorkflowConsumptionis set to true. Enabling this property at runtime has no effect. This means workers have to be restarted after dynamic property changes which is not ideal.Similarly disabling this property doesn't stop consumer manager and requires restart to take effect. In emergency situations it might be handy to quickly stop the async request queue consumption.
Why?
Avoid restarts for enabling/disabling ConsumerManager.
How did you test it?
New unit test which enables, disables and re-enables consumer manager.